Skip to content

Conversation

@openshift-pr-manager
Copy link

Automated merge of upstream/master → master.

Lei Huang and others added 13 commits August 15, 2025 21:18
In the current implementation, UDN is translated to NAD, but only labels
are copied, annotations are not.

This change ensures the annotations are also copied to support correct behavior.

Signed-off-by: Lei Huang <[email protected]>
Signed-off-by: Yun Zhou <[email protected]>
- Add VF device support for primary UDN interface

To request the primary UDN interface of a pod to be backed by a VF
interface, one needs to specifiy the k8s.v1.cni.cncf.io/resourceName
annotation in the primary UDN to request the VF's associated network
resource.

The pod with the primary UDN interface needs to increase its resources
limits and requests for the network resource the primary UDN interface
needs. Note that is out of the scope of ovn-kubernetes.

Signed-off-by: Yun Zhou <[email protected]>
This reverts commit 089009c.

Signed-off-by: Nadia Pinaeva <[email protected]>
This global knob helps to enable (or) disable pod isolation between
BGP advertised UDN networks. The routed udn isolation is enabled
by default. This can be disabled on kind with -rnd or
--routed-udn-isolation-disable options while setting up the cluster.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
When Routed UDN Isolation is disabled, then ovnk must skip programming
advertised network isolation rules on the given node so that traffic
between advertised UDN networks can be steered out from the ovn overlay
network, then with additional manual networking configuration in the
underlay network inter UDN traffic can be made to work.
To facilitate this, this commit skips programming network isolation rules
when the routed udn isolation option is disabled.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
Co-Authored-by: Peng Liu <[email protected]>
Signed-off-by: Periyasamy Palanisamy <[email protected]>
…ose mode

In the advertised UDN isolation loose mode test, cross-UDN traffic
will be routed by the external FRR router. Nodes shall send the UDN
pod outbound traffic to the FRR router as the nexthop.

Signed-off-by: Peng Liu <[email protected]>
- Add ingress flows to table 0 (priority 300/301) for MEG-enabled
  pods, advertised UDNs, and node management traffic, ensuring these
  are handled earlier in the pipeline. In LGW mode, the 301 flow is
  unnecessary, as the traffic to mgmtIP will be forward to host
  kernel by the 300 flow.
- Remove corresponding lower-priority flows (priority 15/16) from
  table 1 to avoid duplication and improve processing efficiency.
- Modify egress flows in table 0 (priority 104/103, previous 109/104)
  for advertised UDN or MEG egress traffic by not setting CT mark and
  send to physical network directly.

example flows in SGW mode EIP enabled:
	table=0, n_packets=0, n_bytes=0, priority=300,ip,in_port=eth0,nw_dst=<nodeSubnet> actions=output:4
	table=0, n_packets=0, n_bytes=0, priority=301,ip,in_port=eth0,nw_dst=<mgmtIP> actions=output:LOCAL
	table=0, n_packets=0, n_bytes=0, priority=104,ip,in_port=4,dl_src=02:42:ac:12:00:03,nw_src=<nodeSubnet> actions=output:eth0
	table=0, n_packets=0, n_bytes=0, priority=103,ip,in_port=4,nw_src=<clusterSubnet> actions=drop

example flows in LGW mode EIP enabled:
	table=0, n_packets=0, n_bytes=0, priority=300,ip,in_port=eth0,nw_dst=<nodeSubnet> actions=output:LOCAL
	table=0, n_packets=0, n_bytes=0, priority=104,ip,in_port=LOCAL,dl_src=02:42:ac:12:00:03,nw_src=<nodeSubnet> actions=output:eth0
	table=0, n_packets=0, n_bytes=0, priority=103,ip,in_port=4,nw_src=<clusterSubnet> actions=drop

example flows in SGW mode EIP disabled:
	table=0, n_packets=0, n_bytes=0, priority=300,ip,in_port=eth0,nw_dst=<nodeSubnet> actions=output:4
	table=0, n_packets=0, n_bytes=0, priority=301,ip,in_port=eth0,nw_dst=<mgmtIP> actions=output:LOCAL
	table=0, n_packets=0, n_bytes=0, priority=104,ip,in_port=4,dl_src=02:42:ac:12:00:03,nw_src=<nodeSubnet> actions=output:eth0

example flows in LGW mode EIP disabled:
	table=0, n_packets=0, n_bytes=0, priority=300,ip,in_port=eth0,nw_dst=<nodeSubnet> actions=output:LOCAL
        table=0, n_packets=0, n_bytes=0, priority=104,ip,in_port=LOCAL,dl_src=02:42:ac:12:00:03,nw_src=<nodeSubnet> actions=output:eth0

Signed-off-by: Peng Liu <[email protected]>
…solation-mode

The configuration parameter 'routed-udn-isolation' has been renamed to
'advertised-udn-isolation-mode' to more accurately reflect its purpose as
a mode of operation rather than a simple boolean toggle.

The corresponding values have been changed from 'enabled'/'disabled' to
'strict'/'loose' for better clarity:
 - 'strict' (formerly 'enabled') enforces complete isolation between UDNs.
 - 'loose' (formerly 'disabled') allows for more relaxed connectivity.

Signed-off-by: Peng Liu <[email protected]>
add unprivileged CNI mode and hw offload support for primary UDN
Revert "Skip session affinity conformance test"
@openshift-pr-manager
Copy link
Author

/ok-to-test
/payload 4.20 ci blocking
/payload 4.20 nightly blocking

@openshift-ci-robot
Copy link
Contributor

@openshift-pr-manager[bot]: This pull request explicitly references no jira issue.

In response to this:

Automated merge of upstream/master → master.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2025
@openshift-ci openshift-ci bot requested review from jcaamano and kyrtapz August 20, 2025 00:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@openshift-pr-manager[bot]: user openshift-pr-manager[bot] is not trusted for pull request #2729

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 20, 2025
@jluhrsen
Copy link
Contributor

/retest
/payload 4.20 ci blocking
/payload 4.20 nightly blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@jluhrsen: trigger 5 job(s) of type blocking for the ci release of OCP 4.20

  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks
  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3fa04060-7d83-11f0-917b-d82d100294a5-0

trigger 10 job(s) of type blocking for the nightly release of OCP 4.20

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3fa04060-7d83-11f0-917b-d82d100294a5-1

@Meina-rh
Copy link

/retitle OCPBUGS-55962: DownStream Merge [08-20-2025]

@openshift-ci openshift-ci bot changed the title NO-JIRA: DownStream Merge [08-20-2025] OCPBUGS-55962: DownStream Merge [08-20-2025] Aug 20, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-pr-manager[bot]: This pull request references Jira Issue OCPBUGS-55962, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Meina-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Automated merge of upstream/master → master.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 20, 2025
@openshift-ci openshift-ci bot requested a review from Meina-rh August 20, 2025 05:40
@Meina-rh
Copy link

/test e2e-aws-ovn-fdp-qe

@jcaamano
Copy link
Contributor

/override ci/prow/lint
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

@jcaamano
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@tssurya: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b88c910-7dba-11f0-8a85-80f21f39e96b-0

@tssurya
Copy link
Contributor

tssurya commented Aug 20, 2025

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@tssurya: aborted active payload jobs for pull request #2729

@jcaamano
Copy link
Contributor

So periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks failure is not uncommon, this time it happen with CNO pod but it does happen with certain frequency on other pods as well. In this specific case CNO pod failed to connect to management cluster API, was restarted and things proceeded normally then. Doesn't look like an issue on this PR. Will run the job seeking a pass.

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@jcaamano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aks

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b069da60-7dc2-11f0-9631-dfc8c7ba4345-0

@jcaamano
Copy link
Contributor

jcaamano commented Aug 20, 2025

For periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips, a fake node deletion is permafailing:

E0820 08:25:31.712464    3856 obj_retry.go:349] Retry delete failed final attempt for *v1.Node e2e-fake-node-8rn9t: error: failed to delete IPs from openshift-host-network address_set: error parsing annotation for node e2e-fake-node-8rn9t: failed to get join switch port IP address for node e2e-fake-node-8rn9t: failed to generate gateway router port address for node e2e-fake-node-8rn9t: k8s.ovn.org/node-id annotation not found for node e2e-fake-node-8rn9t/k8s.ovn.org/node-gateway-router-lrp-ifaddr annotation not found for node "e2e-fake-node-8rn9t"

because of a missing nodeID annotation.

UPDATE: I guess what could be happening is that a node is being added and deleted quick enough as to not giving enough time for clustermanager to annotate it. Being able to process a node deletion should not depend on what clustermanager does or does not do to a node.

This could probably be a bug or an improvement on our deletion flow but I see no changes on this PR that could have triggered the problem now. Maybe a new test or a change on the job itself? Triggering another batch of aggregates while we continue looking.

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@jcaamano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/41de9f60-7dca-11f0-9a0d-94fc90de5b5e-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@jcaamano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a7c7210-7dce-11f0-86a8-fb10a7ddba09-0

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcaamano
Copy link
Contributor

For periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips, a fake node deletion is permafailing:

E0820 08:25:31.712464    3856 obj_retry.go:349] Retry delete failed final attempt for *v1.Node e2e-fake-node-8rn9t: error: failed to delete IPs from openshift-host-network address_set: error parsing annotation for node e2e-fake-node-8rn9t: failed to get join switch port IP address for node e2e-fake-node-8rn9t: failed to generate gateway router port address for node e2e-fake-node-8rn9t: k8s.ovn.org/node-id annotation not found for node e2e-fake-node-8rn9t/k8s.ovn.org/node-gateway-router-lrp-ifaddr annotation not found for node "e2e-fake-node-8rn9t"

because of a missing nodeID annotation.

UPDATE: I guess what could be happening is that a node is being added and deleted quick enough as to not giving enough time for clustermanager to annotate it. Being able to process a node deletion should not depend on what clustermanager does or does not do to a node.

This could probably be a bug or an improvement on our deletion flow but I see no changes on this PR that could have triggered the problem now. Maybe a new test or a change on the job itself? Triggering another batch of aggregates while we continue looking.

The related test case seems to be [sig-node] Node Lifecycle should run through the lifecycle of a node [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s] and changes made on the previous DS merge which included http://github.com/ovn-kubernetes/ovn-kubernetes/pull/5396 seem to be a contributing factor. Tentative upstream fix/improvement: ovn-kubernetes/ovn-kubernetes#5506

@jcaamano
Copy link
Contributor

/override ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
Failing due to
https://issues.redhat.com/browse/OCPBUGS-59496
https://issues.redhat.com/browse/OCPBUGS-57477

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
Failing due to
https://issues.redhat.com/browse/OCPBUGS-59496
https://issues.redhat.com/browse/OCPBUGS-57477

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcaamano
Copy link
Contributor

/lgtm
/approve
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, openshift-pr-manager[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
@asood-rh
Copy link
Contributor

asood-rh commented Aug 20, 2025

e2e-aws-ovn-fdp-qe
Only 1 failure, not a product issue. Interrupted after 35 mins as per time stamps (2096.330 secs)

  Summarizing 1 Failure:
    [INTERRUPTED] [sig-networking] SDN IPSEC EW [It] Author:anusaxen-Medium-83672-[FdpOvnOvs][Skipped Setup] IPSec Functionality check for FDP usecase. [Disruptive]
    /go/src/github.com/openshift/openshift-tests-private/test/extended/networking/ipsec.go:859

  Ran 1 of 1 Specs in 2096.330 seconds
  FAIL! - Interrupted by User -- 0 Passed | 1 Failed | 0 Pending | 0 Skipped
fail [github.com/openshift/openshift-tests-private/test/extended/networking/ipsec.go:859]: Interrupted by User

@jcaamano
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cb5375b into master Aug 21, 2025
43 of 50 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-pr-manager[bot]: Jira Issue OCPBUGS-55962: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-55962 has not been moved to the MODIFIED state.

In response to this:

Automated merge of upstream/master → master.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Meina-rh
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Meina-rh: Jira Issue OCPBUGS-55962: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55962 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.21.0-202508212332.p0.gcb5375b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.21.0-202508212332.p0.gcb5375b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.21.0-202508212332.p0.gcb5375b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.